Link permissions #20846
Merged
Link permissions #20846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable19 |
skjnldsv
reviewed
May 6, 2020
| @@ -511,6 +502,11 @@ public function createShare( | |||
| $permissions = Constants::PERMISSION_READ; | |||
| } | |||
|
|
|||
| // TODO: It might make sense to have a dedicated setting to allow/deny converting link shares into federated ones | |||
| if (($permissions & Constants::PERMISSION_READ)$this->shareManager->outgoingServer2ServerSharesAllowed()) { | |||
|
It still doesn't change the issue about the front end then. |
Ah, actually it might 🤔 |
Not really. But the feeration part that we use instally to check this uses the ShareManager. Basically this fix is not pretty. But it makes the state consistent. The hack for the frontend stays in place for now. It is not ideal I know. |
skjnldsv
approved these changes
May 7, 2020
MorrisJobke
approved these changes
May 8, 2020
|
Failing tests 🙈 |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
fix/link_fed_perm
branch
from
73e558a
to
8289565
Compare
juliusknorr
approved these changes
May 15, 2020
|
Rebased and pushed a fix for the failing test as well. |
MorrisJobke
approved these changes
May 18, 2020
juliusknorr
added
4. to release
This was referenced May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #20726
Turns out we do need the permission in the DB. Else the federated code still chokes as it doesn't use the API.
Also updated the tests to reflect the new situation.